Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time-activity overlap with wide fonts #699

Merged

Conversation

GeraldJansen
Copy link
Contributor

Fixes #698. The width alotted to the time interval in the overview was
fixed at 100 pixels but that was not sufficient when using large/wide
fonts. This PR uses the pixel width of ""00:00 - 00:00" when rendered
using the current default font.

Fixes projecthamster#698. The width alotted to the time interval in the overview was
fixed at 100 pixels but that was not sufficient when using large/wide
fonts. This PR uses the pixel width of ""00:00 - 00:00" when rendered
using the current default font.
This was referenced Mar 27, 2023
Copy link
Member

@aquaherd aquaherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no veto I am going to merge this.

Copy link
Member

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this, but the code and commit message looks good to me.

@aquaherd aquaherd merged commit d537c5f into projecthamster:master Mar 28, 2023
@aquaherd
Copy link
Member

aquaherd commented Apr 2, 2023

While testing this I put in a 20pt Font and it looked good on the time ranges.

However in the German locale, the weekday names were cut off.

Maybe you could apply the same approach to calculate the leftmost panel width?

@GeraldJansen GeraldJansen deleted the fix-time-activity-overlap branch April 2, 2023 19:17
@GeraldJansen
Copy link
Contributor Author

@aquaherd Unfortunately, it is not so simple. As the attached screenshot shows, shows, with a 20pt font and my 1920x1080 screen resolution, there are a number of problems (day name is clipped, long fact description overlaps duration, duration display is messed up). The graphics are coded with a bunch of fixed widths with constants in pixels (500x400 starting screen, 105 pixel left margin, 80 pixel duration field, etc.). The whole thing was not really designed to scale for hires monitors and very large fonts. I guess we should create a new ticket if this is worth pursuing.
Screenshot_2023-04-03_10-50-30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time in Activity Overview Overlaps Activity Title
3 participants